fix(@angular-devkit/build-angular): conditionally enable deprecated Less stylesheet JavaScript support#25639
Merged
alan-agius4 merged 1 commit intoangular:mainfrom Oct 11, 2023
Conversation
alan-agius4
added
the
needs: discussion
Closed
13 tasks
|
Is there any progress? |
clydin
added
target: major
…ess stylesheet JavaScript support When a Less stylesheet is detected to require the deprecated `javascriptEnabled` Less option, the option is enabled for the stylesheet and a warning is issued to inform the user of the behavior change. The Less `javascriptEnabled` option has been deprecated and disabled by default since Less v3 (https://github.com/less/less.js/releases/tag/v3.0.0). When enabled, the `javascriptEnabled` option allows JavaScript within Less stylesheets to be executed at build time. Less option reference: https://lesscss.org/usage/#less-options This provides similar behavior to the default Webpack-based build system. However, the Webpack-based build system currently unconditionally enables the option.
clydin
force-pushed
the
esbuild/less-inline-js
branch
from
8778bb0 to
d85cbf6
Compare
clydin
added
the
action: review
alan-agius4
approved these changes
Oct 11, 2023
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a Less stylesheet is detected to require the deprecated
javascriptEnabledLess option, the option is enabled for the stylesheet and a warning is issued to inform the user of the behavior change. The LessjavascriptEnabledoption has been deprecated and disabled by default since Less v3 (https://github.com/less/less.js/releases/tag/v3.0.0). When enabled, thejavascriptEnabledoption allows JavaScript within Less stylesheets to be executed at build time.Less option reference: https://lesscss.org/usage/#less-options
This provides similar behavior to the default Webpack-based build system. However, the Webpack-based build system currently unconditionally enables the option.
Closes #25572